Implementation Plan: T5-P6-A2-WP1 Close Test Gap for config.toml auto_compact_limit Override + ADR#4123
Merged
Trecek merged 3 commits intoJun 27, 2026
Conversation
…DR-0004 Adds test_copied_config_has_auto_compact_limit to TestCodexBackendSetupSessionDir to verify that setup_session_dir copies config.toml with the model_auto_compact_token_limit override intact. No production code changes needed; the test confirms shutil.copy2 behavior. Also creates ADR-0004 documenting load_recipe as the sanctioned channel for recipe knowledge re-delivery after Codex context compaction, and adds it to the docs/decisions/README.md index.
…imit key setup_session_dir uses shutil.copy2 faithfully — when the source config.toml lacks model_auto_compact_token_limit, the session config also lacks it. test_session_config_lacks_key_when_source_lacks_it documents this contract, closing the negative-case gap noted in the PR review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a test asserting that
setup_session_dircopiesconfig.tomlwith themodel_auto_compact_token_limitoverride intact, and create ADR-0004 documenting the sanctionedload_recipere-delivery design decision. The test verifies the existingshutil.copy2behavior preserves the override — no production code changes needed.Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260627-022900-498677/.autoskillit/temp/make-plan/t5-p6-a2-wp1-close-test-gap-config-toml-auto-compact_plan_2026-06-27_030300.mdCloses #4051
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown